Feat/visualization #258
Merged
Feat/visualization #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add method to_xyz to math.py
- revert changes to classification.py - lint
Co-authored-by: Quentin Barthélemy <q.barthelemy@gmail.com>
Co-authored-by: Quentin Barthélemy <q.barthelemy@gmail.com>
Co-authored-by: Quentin Barthélemy <q.barthelemy@gmail.com>
qbarthelemy
reviewed
Mar 26, 2024
doc/requirements.txt
Outdated
| @@ -17,6 +17,6 @@ qiskit-optimization==0.5.0 | |||
| qiskit-aer==0.12.2 | |||
| scipy==1.11.4 | |||
| moabb>=1.0.0 | |||
| pyriemann==0.5 | |||
| git+https://github.com/pyRiemann/pyRiemann#egg=pyriemann | |||
There was a problem hiding this comment.
Can you apply the same modification in setup.py ?
There was a problem hiding this comment.
Unfortunately, I don't think it will be possible to publish on pypi if we point to the dev version in the setup.py.
|
Conflict with pyRiemann and moabb:
|
qbarthelemy
approved these changes
Mar 27, 2024
Co-authored-by: Quentin Barthélemy <q.barthelemy@gmail.com>
Co-authored-by: Quentin Barthélemy <q.barthelemy@gmail.com>
|
Thanks @qbarthelemy ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a module to hold our visualization utils:
distances histogram (by @qbarthelemy)
scatter plot of the distances:
plot SPDs matrices in 3d cartesian coordinates:
