-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a new benchmark over many datasets #264
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It gives an error: AttributeError: Pipeline has none of the following attributes: decision_function.
Added an example that runs on a small number of test samples, so that we can get results quicker.
- limite size of training set - change to slsqp optimizer
Merge branch 'main' of https://github.com/toncho11/pyRiemann-qiskit-rep
Added second parameter that specifies the number of hulls.
Added support for transform(). Added a new pipeline [NCH+LDA]
Improvements requested by GC.
…Imagery databases. It automatically handles paradigms and pipelines differences.
Added documentation. Improved statistical plots. Added parameters.
@toncho11 Do you want to update up-merge your branch and update your code with the latest changes? I could reuse this pipeline also to benchmark the NCH. |
gcattan
approved these changes
Jun 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx @toncho11 :)
But this benchmark requires the latest version of MOABB from git. |
I mean after MOABB 1.1.0. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It does include many P300 and Motor Imagery datasets.
It adapts both the paradigms and the pipelines.
And most importantly it runs statistics to show if the results are significant (using moabb).
The initial version can be run already.
Currently it requires the latest version of MOABB from github where:
-
cache_config
parameter is availabe for WithinSessionEvaluation()- this bug is fixed: NeuroTechX/moabb#514