Chores/qiskit 1.0.2 #275

gcattan · 2024-04-30T12:18:27Z

Follow-up for #272

Part of: #265

gcattan · 2024-04-30T12:29:50Z

The qiskit-ibm-provider dependency needs to be replaced by qiskit_ibm_runtime:
https://docs.quantum.ibm.com/api/migration-guides/qiskit-runtime-from-ibm-provider

gcattan · 2024-04-30T12:53:15Z

Need to test connection to real backend.

frankharkins · 2024-05-02T09:18:52Z

requirements.txt

@@ -2,10 +2,10 @@ numpy<1.27
 cython
 scikit-learn==1.3.2
 git+https://github.com/pyRiemann/pyRiemann#egg=pyriemann
-qiskit==0.46.1
+qiskit==1.0.2


Consider pinning to ==1.*. One of the features of the 1.0 release is the stability guarantee that no versions of Qiskit 1.x will break compatibility. Same for the setup.py.

toncho11 · 2024-05-03T15:50:24Z

I am testing the connection to real backend with the code from this PR and I get:

from pyriemann_qiskit.utils.quantum_provider import get_quantum_kernel
File "C:\Work\PythonCode\pyRiemann-qiskit\pyq_env\Lib\site-packages\pyriemann_qiskit\utils_init_.py", line 1, in
from . import hyper_params_factory, filtering, preprocessing
File "C:\Work\PythonCode\pyRiemann-qiskit\pyq_env\Lib\site-packages\pyriemann_qiskit\utils\hyper_params_factory.py", line 1, in
from qiskit.circuit.library import ZZFeatureMap, ZFeatureMap, PauliFeatureMap
File "C:\Work\PythonCode\pyRiemann-qiskit\pyq_env\Lib\site-packages\qiskit_init_.py", line 36, in
raise ImportError(
ImportError: Qiskit is installed in an invalid environment that has both Qiskit >=1.0 and an earlier version. You should create a new virtual environment, and ensure that you do not mix dependencies between Qiskit <1.0 and >=1.0. Any packages that depend on 'qiskit-terra' are not compatible with Qiskit 1.0 and will need to be updated. Qiskit unfortunately cannot enforce this requirement during environment resolution. See https://qisk.it/packaging-1-0 for more detail.

I have Qiskit 1.0.2 currently installed and qiskit-terra 0.46.1.

toncho11 · 2024-05-03T15:56:36Z

Also I did switch simulator to False in order not to use a real quantum computer time in quantum_provider.py

return provider.least_busy(
operational=True, simulator=False, min_num_qubits=min_qubits
)

gcattan · 2024-05-06T10:25:32Z

@toncho11 simulator is False by default.
For your problem, I had the same. You can uninstall qiskit-terra.

gcattan · 2024-05-06T11:15:03Z

There is no regression in scores. Light benchmark is failing because qiskit-terra and qiskit got installed in the same container:

On local, to solve this error, you have to go into your environment folder and delete all qiskit folder, then reinsall qiskit 1.0.2.

On Ci, this happen because main is on qiskit-terra and the PR on qiskit 1.0. This will solve itself when we will merge.

toncho11 · 2024-05-06T12:14:15Z

Sorry, I set simulator=True in this case where I would like to use a simulated backend.

gcattan · 2024-05-07T11:21:07Z

I am able to get a remote instance, but I have this error message so for:

gcattan · 2024-05-07T18:59:23Z

Ok, the test dataset corresponds to 64620 circuits, and the capacity of the quantum computer is only 300 circuits per job, so I guess it is why we have so many jobs.

Changing the optimization_level for the transpiler doesn't help that much, we just need to provide less data - but this is another problem we need to address.

Here is a snapshot of the three first jobs executed in the quantum computer:

I think we are ready to merge. @toncho11 @frankharkins

toncho11 · 2024-05-07T20:33:59Z

Currently I am getting:

File "C:\Work\PythonCode\pyRiemann-qiskit\examples\ERP\plot_classify_P300_bi_test_provider.py", line 36, in <module>
    from pyriemann_qiskit.pipelines import (
  File "C:\Work\PythonCode\pyRiemann-qiskit\pyq_env\Lib\site-packages\pyriemann_qiskit\__init__.py", line 2, in <module>
    from . import classification, pipelines, ensemble
  File "C:\Work\PythonCode\pyRiemann-qiskit\pyq_env\Lib\site-packages\pyriemann_qiskit\classification.py", line 8, in <module>
    from pyriemann_qiskit.utils.quantum_provider import get_quantum_kernel
  File "C:\Work\PythonCode\pyRiemann-qiskit\pyq_env\Lib\site-packages\pyriemann_qiskit\utils\__init__.py", line 1, in <module>
    from . import hyper_params_factory, filtering, preprocessing
  File "C:\Work\PythonCode\pyRiemann-qiskit\pyq_env\Lib\site-packages\pyriemann_qiskit\utils\hyper_params_factory.py", line 1, in <module>
    from qiskit.circuit.library import ZZFeatureMap, ZFeatureMap, PauliFeatureMap
ImportError: cannot import name 'ZZFeatureMap' from 'qiskit.circuit.library' (unknown location)

gcattan · 2024-05-07T20:54:51Z

Yeah. There is some namespace conflict I think between qiskit-terra and qiskit. What worked for me was to go to my environment site-packages Delete all qiskit folders Reinstall qiskit 1.0.2 Envoyé à partir de Outlook pour Android<https://aka.ms/AAb9ysg>

…

________________________________ From: toncho11 ***@***.***> Sent: Tuesday, May 7, 2024 10:34:20 PM To: pyRiemann/pyRiemann-qiskit ***@***.***> Cc: gcattan ***@***.***>; Author ***@***.***> Subject: Re: [pyRiemann/pyRiemann-qiskit] Chores/qiskit 1.0.2 (PR #275) Currently I am getting: from . import hyper_params_factory, filtering, preprocessing File "C:\Work\PythonCode\pyRiemann-qiskit\pyq_env\Lib\site-packages\pyriemann_qiskit\utils\hyper_params_factory.py", line 1, in <module> from qiskit.circuit.library import ZZFeatureMap, ZFeatureMap, PauliFeatureMap ImportError: cannot import name 'ZZFeatureMap' from 'qiskit.circuit.library' (unknown location) — Reply to this email directly, view it on GitHub<#275 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABPQYJZCTN5I6DICPZC6G6TZBE3EZAVCNFSM6AAAAABHAEX65GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJZGI3DEMRQG4>. You are receiving this because you authored the thread.Message ID: ***@***.***>

gcattan · 2024-05-07T20:55:46Z

If you start from a clean env, it should work right away I believe. Envoyé à partir de Outlook pour Android<https://aka.ms/AAb9ysg>

…

________________________________ From: toncho11 ***@***.***> Sent: Tuesday, May 7, 2024 10:34:20 PM To: pyRiemann/pyRiemann-qiskit ***@***.***> Cc: gcattan ***@***.***>; Author ***@***.***> Subject: Re: [pyRiemann/pyRiemann-qiskit] Chores/qiskit 1.0.2 (PR #275) Currently I am getting: from . import hyper_params_factory, filtering, preprocessing File "C:\Work\PythonCode\pyRiemann-qiskit\pyq_env\Lib\site-packages\pyriemann_qiskit\utils\hyper_params_factory.py", line 1, in <module> from qiskit.circuit.library import ZZFeatureMap, ZFeatureMap, PauliFeatureMap ImportError: cannot import name 'ZZFeatureMap' from 'qiskit.circuit.library' (unknown location) — Reply to this email directly, view it on GitHub<#275 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABPQYJZCTN5I6DICPZC6G6TZBE3EZAVCNFSM6AAAAABHAEX65GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJZGI3DEMRQG4>. You are receiving this because you authored the thread.Message ID: ***@***.***>

toncho11 · 2024-05-08T07:53:17Z

to go to my environment site-packages Delete all qiskit folders Reinstall qiskit 1.0.2

Yes. It worked.

Punctuation fix.

gcattan added 2 commits April 30, 2024 14:16

update qiskit and qiskit-ibm-provider

3455879

fix wrong reference to qiskit_algorithm

46e6563

gcattan and others added 2 commits April 30, 2024 14:49

switch to runtime service

8e96dac

[pre-commit.ci] auto fixes from pre-commit.com hooks

89b2d12

gcattan and others added 3 commits April 30, 2024 14:54

update urllib

dd0bdab

update benchmark script

ca7a8bf

[pre-commit.ci] auto fixes from pre-commit.com hooks

5df7a7d

frankharkins reviewed May 2, 2024

View reviewed changes

pin to qiskit==1.*

8a6f789

gcattan and others added 2 commits May 6, 2024 12:31

fix commit

0987fae

[pre-commit.ci] auto fixes from pre-commit.com hooks

4eef9eb

gcattan and others added 2 commits May 7, 2024 13:20

fix bug with quantum_provider

08af1af

[pre-commit.ci] auto fixes from pre-commit.com hooks

5208182

gcattan marked this pull request as ready for review May 7, 2024 18:59

Update quantum_provider.py

821d734

Punctuation fix.

toncho11 approved these changes May 8, 2024

View reviewed changes

gcattan merged commit 5e7c987 into pyRiemann:main May 8, 2024
12 of 13 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Chores/qiskit 1.0.2 #275

Chores/qiskit 1.0.2 #275

gcattan commented Apr 30, 2024 •

edited

Loading

gcattan commented Apr 30, 2024 •

edited

Loading

gcattan commented Apr 30, 2024

frankharkins May 2, 2024

toncho11 commented May 3, 2024 •

edited

Loading

toncho11 commented May 3, 2024 •

edited

Loading

gcattan commented May 6, 2024

gcattan commented May 6, 2024

toncho11 commented May 6, 2024

gcattan commented May 7, 2024

gcattan commented May 7, 2024

toncho11 commented May 7, 2024 •

edited

Loading

gcattan commented May 7, 2024 via email

gcattan commented May 7, 2024 via email

toncho11 commented May 8, 2024

Chores/qiskit 1.0.2 #275

Chores/qiskit 1.0.2 #275

Conversation

gcattan commented Apr 30, 2024 • edited Loading

gcattan commented Apr 30, 2024 • edited Loading

gcattan commented Apr 30, 2024

frankharkins May 2, 2024

Choose a reason for hiding this comment

toncho11 commented May 3, 2024 • edited Loading

toncho11 commented May 3, 2024 • edited Loading

gcattan commented May 6, 2024

gcattan commented May 6, 2024

toncho11 commented May 6, 2024

gcattan commented May 7, 2024

gcattan commented May 7, 2024

toncho11 commented May 7, 2024 • edited Loading

gcattan commented May 7, 2024 via email

gcattan commented May 7, 2024 via email

toncho11 commented May 8, 2024

gcattan commented Apr 30, 2024 •

edited

Loading

gcattan commented Apr 30, 2024 •

edited

Loading

toncho11 commented May 3, 2024 •

edited

Loading

toncho11 commented May 3, 2024 •

edited

Loading

toncho11 commented May 7, 2024 •

edited

Loading