Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gc/get feature dimension #50

Merged
merged 6 commits into from
Jun 6, 2022
Merged

Gc/get feature dimension #50

merged 6 commits into from
Jun 6, 2022

Conversation

gcattan
Copy link
Collaborator

@gcattan gcattan commented Jun 3, 2022 •
edited
Loading

@toncho11 starting small with #48 :

get_feature_dimension disappeared from qiskit-ml in this commit.
I am reintroducing this method here.

@gcattan gcattan marked this pull request as ready for review June 3, 2022 10:38
qbarthelemy
qbarthelemy requested changes Jun 6, 2022
View reviewed changes
Copy link
Member

@qbarthelemy qbarthelemy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add unitary tests for this new function?

pyriemann_qiskit/datasets/utils.py Outdated Show resolved Hide resolved
gcattan and others added 2 commits June 6, 2022 10:56
@gcattan
add unit tests
5ed205e 
(cherry picked from commit e86936e)
@gcattan @qbarthelemy
Update pyriemann_qiskit/datasets/utils.py
f99f72e 
Co-authored-by: Quentin Barthélemy <q.barthelemy@gmail.com>
gcattan and others added 2 commits June 6, 2022 20:02
@gcattan @qbarthelemy
Update pyriemann_qiskit/datasets/utils.py
c803cc9 
Co-authored-by: Quentin Barthélemy <q.barthelemy@gmail.com>
@gcattan @qbarthelemy
Update pyriemann_qiskit/datasets/utils.py
bb6157d 
Co-authored-by: Quentin Barthélemy <q.barthelemy@gmail.com>
qbarthelemy
qbarthelemy approved these changes Jun 6, 2022
View reviewed changes
Copy link
Member

@qbarthelemy qbarthelemy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx @gcattan

@qbarthelemy qbarthelemy merged commit a53f2f8 into pyRiemann:main Jun 6, 2022
@gcattan
Copy link
Collaborator Author

gcattan commented Jun 6, 2022

Thanks for the review :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qbarthelemy qbarthelemy qbarthelemy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gcattan @qbarthelemy