Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme with FAQ and contributors guidelines. #55

Merged
merged 2 commits into from
Jun 20, 2022

Conversation

gcattan
Copy link
Collaborator

@gcattan gcattan commented Jun 18, 2022

Issue #52.
Follow-up for #51 as per @toncho11 comment.
I was able to reproduce the issue with the pyRiemann dependency not being updated after running python setup.py develop.

@toncho11
Copy link
Collaborator

This sentence is not clear "To prevent any furthur issues, we recommand to execute before installing or updating pyRiemann-qiskit:". There is also a typo "recommand" and "furthur".

Here aslo: "We recommand the use of".

Anton's review
@gcattan
Copy link
Collaborator Author

gcattan commented Jun 20, 2022

Thanks @toncho11 :)

@gcattan gcattan merged commit 3e61058 into pyRiemann:main Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants