Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abstract for JOSS journal #70

Merged
merged 28 commits into from
Nov 23, 2022
Merged

Abstract for JOSS journal #70

merged 28 commits into from
Nov 23, 2022

Conversation

gcattan
Copy link
Collaborator

@gcattan gcattan commented Sep 11, 2022

The full JOSS recommendation are here. Below, the summary:

image

The compiled PDF version is downloadable as an artifact here.

@gcattan gcattan changed the title Gc/joss Abstract for JOSS journal Sep 11, 2022
Update qiskit_terra version on Dockerfile
@gcattan gcattan marked this pull request as ready for review September 16, 2022 14:31
Update with recent modification in the Wiki
@gcattan
Copy link
Collaborator Author

gcattan commented Sep 26, 2022

@toncho11 I have updated the paper with the latest text from the wiki. Please, review when you have time.

@gcattan
Copy link
Collaborator Author

gcattan commented Sep 29, 2022

@toncho11 will have little time to work on this abstract. @qbarthelemy or @sylvchev will you be available to review this?

@qbarthelemy
Copy link
Member

It's a good idea, but I think that we should publish pyRiemann before. @sylvchev @plcrodrigues @agramfort

@plcrodrigues
Copy link
Member

It's a good idea, but I think that we should publish pyRiemann before. @sylvchev @plcrodrigues @agramfort

Agreed.

@toncho11
Copy link
Collaborator

toncho11 commented Oct 1, 2022

I am not sure. How much time will take to publish pyRiemann? This risks blocking pyRiemann-Qiskit for a very long time.

@agramfort
Copy link
Member

We should consider publishing a JOSS paper on pyRiemann yes. To cite pyRiemann in this paper we can use a zenodo DOI but I am moderately convinced it's useful in the long run.

@gcattan
Copy link
Collaborator Author

gcattan commented Oct 2, 2022

Once pyRiemann is published on JoSS, I think we still have time to update the reference to it in this paper. pyRiemann-qiskit is not as mature as pyRiemann and I think it will take some time before it gets published. This is why it may be a good idea to start the process soon, what do you think ?

Side question: do you want me to prepare the workflow in pyRiemann repo ?

@gcattan
Copy link
Collaborator Author

gcattan commented Oct 7, 2022

Hello. Did you have some time to think about it?

@gcattan
Copy link
Collaborator Author

gcattan commented Oct 10, 2022

Ok, I am not sure what action I need to take for this PR now. Shall we proceed or wait for pyRiemann? If yes, is something like the end of november could work? @qbarthelemy

@agramfort
Copy link
Member

agramfort commented Oct 10, 2022 via email

@sylvchev
Copy link
Member

Yes, I have a draft for Pyriemann targeting https://jmlr.org/mloss/ that I need to reorganize before sharing. It will happen soon!

@gcattan
Copy link
Collaborator Author

gcattan commented Oct 10, 2022

Ok, thank you for the update. I will wait for Zenodo DOI and pyRiemann draft to be ready then.
Please, also have a look to this abstract when you have time.

@agramfort
Copy link
Member

agramfort commented Oct 11, 2022 via email

@agramfort
Copy link
Member

agramfort commented Oct 11, 2022 via email

@plcrodrigues
Copy link
Member

a few things for me need to be decided first: - who is onboard? One solution is to add to the paper anyone who contributed in the past but this deserves some discussion I guess. - who is leading this? First author? Senior Author? feel free to voice your opinion

How did you guys do for sklearn ? We have 21 contributors on pyriemann so far, so it could maybe be reasonable to try contacting each person to ask if they want to participate in the paper ? (and ask for some help ?)

@qbarthelemy
Copy link
Member

When we look at the number of lines modified,
it seems to me that we easily find two clusters of contributors.
https://github.com/pyRiemann/pyRiemann/graphs/contributors

@agramfort
Copy link
Member

agramfort commented Oct 11, 2022 via email

@qbarthelemy
Copy link
Member

I would have kept the first seven contributors.
Maybe we should have this discussion on pyRiemann : pyRiemann/pyRiemann#203

@gcattan
Copy link
Collaborator Author

gcattan commented Nov 20, 2022

Hi, do you have some update with the pyriemann paper? If no, I have referenced the Zenodo DOI of pyRiemann so we could start the submission.

@gcattan gcattan merged commit c3b3cd9 into pyRiemann:main Nov 23, 2022
@agramfort
Copy link
Member

@gcattan you can now refer to PyRiemann with this bibtex

https://github.com/pyRiemann/pyRiemann/blob/master/README.md#how-to-cite

@gcattan gcattan mentioned this pull request Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants