fix issue 3668 by removing bool casts in numpy.h (#3669)

Skylion007 · web-flow · commit 978617f6b548 · 2022-01-31T12:57:32.000-05:00
diff --git a/include/pybind11/numpy.h b/include/pybind11/numpy.h
@@ -170,10 +170,10 @@ struct npy_api {
     }
 
     bool PyArray_Check_(PyObject *obj) const {
-        return (bool) PyObject_TypeCheck(obj, PyArray_Type_);
+        return PyObject_TypeCheck(obj, PyArray_Type_) != 0;
     }
     bool PyArrayDescr_Check_(PyObject *obj) const {
-        return (bool) PyObject_TypeCheck(obj, PyArrayDescr_Type_);
+        return PyObject_TypeCheck(obj, PyArrayDescr_Type_) != 0;
     }
 
     unsigned int (*PyArray_GetNDArrayCFeatureVersion_)();

Original file line number	Diff line number	Diff line change
`@@ -170,10 +170,10 @@ struct npy_api {`
`170`	`170`	`}`
`171`	`171`
`172`	`172`	`bool PyArray_Check_(PyObject *obj) const {`
`173`		`- return (bool) PyObject_TypeCheck(obj, PyArray_Type_);`
	`173`	`+ return PyObject_TypeCheck(obj, PyArray_Type_) != 0;`
`174`	`174`	`}`
`175`	`175`	`bool PyArrayDescr_Check_(PyObject *obj) const {`
`176`		`- return (bool) PyObject_TypeCheck(obj, PyArrayDescr_Type_);`
	`176`	`+ return PyObject_TypeCheck(obj, PyArrayDescr_Type_) != 0;`
`177`	`177`	`}`
`178`	`178`
`179`	`179`	`unsigned int (*PyArray_GetNDArrayCFeatureVersion_)();`