Apply c++ standard flag only to files of CXX language #1678
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
-std=c++xx
flag should only be applied toCXX
files. Normally, applying the-std
to all files is harmless because the compiler recognizes but issues a warning on the invalid flag. However, in the sad case where a module to be built contains Fortran files and the std is quite new and the fortran compiler is quite old (e.g., 14 and gfortran 4.8.5), the warning turns to error:Warning: command line option '-std=c++14' is valid for C++/ObjC++ but not for Fortran
-->error: unrecognized command line option '-std=c++14'
.Of the two changes below, the pybind11Config is what worked for my project, but it seemed reasonable to switch the other as well. I haven't built with old cmake versions, but 3.3 is when the docs say cmake learned
COMPILE_LANGUAGE
generator.