Add negative indexing support to stl_bind. #1882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a nice feature addition, but the variable update in an conditional expression is a no-go for me :). I think that it would be cleanest to factor out the arithmetic & throw statement into a small lambda function that takes the array size and requested entry index. |
wjakob
reviewed
Aug 15, 2019
include/pybind11/stl_bind.h
Outdated
| auto wrap_i = [](DiffType i, SizeType n) { | ||
| if (i < 0) | ||
| i += n; | ||
| if (i < 0) |
There was a problem hiding this comment.
Wouldn't it be better to make this check if (i < 0 || i >= n) and then remove the exceptions elsewhere?
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.