Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add clang-tidy readability checks for sus args #3611

Merged
merged 1 commit into from
Jan 12, 2022

Conversation

Skylion007
Copy link
Collaborator

Description

  • Add a clang-tidy readability check for suspicious args (when the arg names are swapped with the function args etc.). Useful for catching bugs.

Suggested changelog entry:

* Add clang-tidy readability check to catch potentially swapped function args

@Skylion007 Skylion007 marked this pull request as ready for review January 11, 2022 23:42
@Skylion007 Skylion007 requested a review from rwgk January 11, 2022 23:42
Copy link
Collaborator

@rwgk rwgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@rwgk
Copy link
Collaborator

rwgk commented Jan 12, 2022

@Skylion007, @henryiii, I'll go ahead merge this now to get it into my smart_holder update batch.

@rwgk rwgk merged commit f8d4aa4 into pybind:master Jan 12, 2022
@github-actions github-actions bot added the needs changelog Possibly needs a changelog entry label Jan 12, 2022
@Skylion007 Skylion007 deleted the clang-tidy-add-readability-sus-call branch January 12, 2022 01:36
@henryiii henryiii removed the needs changelog Possibly needs a changelog entry label Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants