Add static_assert to holder casters #786
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The holder casters assume but don't check that a
holder<type>
'stype
is really atype_caster_base<type>
; this adds astatic_assert
to make sure this is really the case, to turn things likestd::shared_ptr<array>
into a compilation failure.Fixes #785
There is some merit to making the holder casters use a proper
type_caster<type>
rather than atype_caster_base<type>
so that you could, for example, have astd::shared_ptr<std::string>
orstd::unique_ptr<Eigen::MatrixXd>
. With this commit, holder arguments around non-generic type casters fails at compile time; before this commit, those failures show up in strange runtime failures (due to invoking the generic type caster rather than the specialized type caster).