functional: support bound methods #815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interesting -- this case had never occurred to me. Would it be easier to simply not unbox the method in |
|
It looks like other code expects unboxing: removing it causes various other tests to fail with maximum recursion errors. |
If a bound std::function is invoked with a bound method, the implicit bound self is lost because we use `detail::get_function` to unbox the function. This commit amends the code to use py::function and only unboxes in the special is-really-a-c-function case. This makes bound methods stay bound rather than unbinding them by forcing extraction of the c function.
jagerman
force-pushed
the
functional-bound-methods
branch
from
6fcdb7c
to
01946cc
Compare
|
I cleaned it up a bit to go through |
|
LGTM! |
|
Looks good to me! This also reminded me that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a bound std::function is invoked with a bound method, the implicit bound self is lost; the method is called with the first argument as self. This commits adds bound method detection and re-adds the
implicit
selfinto the call arguments for bound methods.Fixes #814.