enum_: fix implicit conversion on Python 2.7 #821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interesting -- looks like PyPy does not pass the new test even with the fix. |
|
The solution to the puzzle is that PyPy generates a type error (rather than a 2.7.x-style system error) when a conversion to an arithmetic type fails. I added a patch that switches PyPy over to the 3.x convention. With that, the test suite now passes on PyPy as well. Any thoughts on this patch? |
Enumerations on Python 2.7 were not always implicitly converted to integers (depending on the target size). This patch adds a __long__ conversion function (only enabled on 2.7) which fixes this issue. The attached test case fails without this patch.
The added flag enables non-buffered console output when using Ninja
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enumerations on Python 2.7 were not always implicitly converted to
integers (depending on the target size). This patch adds a
__long__conversion function (only enabled on 2.7) which fixes this issue.
The attached test case fails without this patch.