Defer None loading to second pass #843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jagerman
force-pushed
the
defer-none-conversion
branch
from
2001708
to
4685c2f
Compare
|
Makes sense -- LGTM! |
This was referenced May 10, 2017
|
Looks good to me. |
Many of our `is_none()` checks in type caster loading return true, but this should really be considered a deferral so that, for example, an overload with a `py::none` argument would win over one that takes `py::none` as a null option. This keeps None-accepting for the `!convert` pass only for std::optional and void casters. (The `char` caster already deferred None; this just extends that behaviour to other casters).
jagerman
force-pushed
the
defer-none-conversion
branch
from
cbea4dc
to
a288ae4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up the discussion in #839, this changes most of the
is_none()checks to defer to theconvert = truepass. This makes them consistent with thecharcaster (which already deferred), and seems more correct. In particular, this allows apy::noneoverload to be used even if earlier overloads would accept aNone.This keeps
Nonein the no-convert pass for the two type casters where it makes sense: the void caster, and thestd::optionalcaster.