New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How do I enforce that pybind11 be installed before my package #20

Closed
zfrenchee opened this Issue Mar 27, 2017 · 4 comments

Comments

Projects
None yet
2 participants
@zfrenchee

zfrenchee commented Mar 27, 2017

I believe that's how to interpret the error below:

~/Documents/GarNet(master*) » pip install pcst_fast
Collecting pcst_fast
  Downloading pcst_fast-1.0.0.tar.gz
Collecting pybind11>=1.7 (from pcst_fast)
  Downloading pybind11-2.1.0-py2.py3-none-any.whl (109kB)
    100% |████████████████████████████████| 112kB 4.4MB/s
Installing collected packages: pybind11, pcst-fast
  Running setup.py install for pcst-fast ... error
...
    src/pcst_fast_pybind.cc:9:10: fatal error: 'pcst_fast.h' file not found
    #include "pcst_fast.h"
             ^
    1 error generated.
    error: command 'clang' failed with exit status 1
@wjakob

This comment has been minimized.

Show comment
Hide comment
@wjakob

wjakob Mar 27, 2017

Member

Not sure how this is related to pybind11. pcst_fast.h is not a pybind11 header file.

Member

wjakob commented Mar 27, 2017

Not sure how this is related to pybind11. pcst_fast.h is not a pybind11 header file.

@zfrenchee

This comment has been minimized.

Show comment
Hide comment
@zfrenchee

zfrenchee Mar 27, 2017

True, I'm using pybind11 for my pcst_fast package. I've used this repo's setup file as a model to build my package, and I can successfully install with setup.py locally, but this fails on pip -- and I believe the reason is because locally I pre-install pybind11 with a pip install pybind11.

So the issue I'm logging is: my claim is this repo is not a correct example of how to build a python package with pybind11 for pypi, or I've messed up some other way. The issue I think I'm having is that, when I put this on pypi, it seems to try to install my package before pybind11, which won't work since my package is all c. @wjakob

zfrenchee commented Mar 27, 2017

True, I'm using pybind11 for my pcst_fast package. I've used this repo's setup file as a model to build my package, and I can successfully install with setup.py locally, but this fails on pip -- and I believe the reason is because locally I pre-install pybind11 with a pip install pybind11.

So the issue I'm logging is: my claim is this repo is not a correct example of how to build a python package with pybind11 for pypi, or I've messed up some other way. The issue I think I'm having is that, when I put this on pypi, it seems to try to install my package before pybind11, which won't work since my package is all c. @wjakob

@zfrenchee

This comment has been minimized.

Show comment
Hide comment
@zfrenchee

zfrenchee Mar 27, 2017

@wjakob this might be a copy of #16

zfrenchee commented Mar 27, 2017

@wjakob this might be a copy of #16

@zfrenchee

This comment has been minimized.

Show comment
Hide comment
@zfrenchee

zfrenchee Mar 28, 2017

Follow the instructions and build a python wheel. http://pythonwheels.com/

zfrenchee commented Mar 28, 2017

Follow the instructions and build a python wheel. http://pythonwheels.com/

@zfrenchee zfrenchee closed this Mar 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment