Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why is the macOS 11/12 wheel dropped? #686

Closed
nelsyeung opened this issue Nov 30, 2023 · 3 comments · Fixed by #687
Closed

Why is the macOS 11/12 wheel dropped? #686

nelsyeung opened this issue Nov 30, 2023 · 3 comments · Fixed by #687

Comments

@nelsyeung
Copy link

Is there a reason why bcrypt dropped building for macOS 11/12? (see 8995a80) Note that this is between 4.0.1 and 4.1.0 and it's not in the changelog.

Some of our jobs tests on older macOSs (namely the latest 3 versions which includes macOS 12), suddenly all failed because it needs to build from source.

@nelsyeung nelsyeung changed the title Why is the macOS 11/12 wheel is dropped? Why is the macOS 11/12 wheel dropped? Nov 30, 2023
@alex
Copy link
Member

alex commented Nov 30, 2023

What version of pip are you installing with?

@nelsyeung
Copy link
Author

nelsyeung commented Nov 30, 2023

23.3.1 our pipeline always runs pip install -U pip setuptools before installing dependencies.

I'm fairly sure that it's macOS 11/12 wheel is dropped. Correct me if I'm wrong, the commit I linked changed from:

runs-on: macos-11

to

needs: [sdist]
runs-on: macos-13

So that the build now outputs bcrypt-4.1.1-cp37-abi3-macosx_13_0_universal2.whl (See https://pypi.org/project/bcrypt/#files).

pip can't match macosx_13_0 to macOS 12, only macOS 13 or higher. Hence, the previously supported macOS 11+ is dropped.

@alex
Copy link
Member

alex commented Nov 30, 2023

Ugh, I see the problem. It's a bad transposition of some code from pyca/cryptography.

alex added a commit to alex/bcrypt that referenced this issue Nov 30, 2023
alex added a commit to alex/bcrypt that referenced this issue Nov 30, 2023
reaperhulk pushed a commit that referenced this issue Nov 30, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants