Skip to content

put the 'version' field into the 'SSL' struct where it belongs; make SSL_CTX opaque. #1983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 19, 2015
Merged

put the 'version' field into the 'SSL' struct where it belongs; make SSL_CTX opaque. #1983

merged 1 commit into from
May 19, 2015

Conversation

glyph
Copy link
Contributor

@glyph glyph commented May 19, 2015

Currently cryptography improperly defines the ssl_st structure as SSL_CTX; this is inaccurate. The typedef lines from ossl_typ.h are:

typedef struct ssl_st SSL;
typedef struct ssl_ctx_st SSL_CTX;

@reaperhulk
Copy link
Member

add to whitelist

@reaperhulk
Copy link
Member

This was a bug introduced in this commit: c4d9141

@reaperhulk reaperhulk added this to the Tenth Release milestone May 19, 2015
reaperhulk added a commit that referenced this pull request May 19, 2015
@reaperhulk
Merge pull request #1983 from glyph/correct-structs
c5db584 
put the 'version' field into the 'SSL' struct where it belongs; make SSL_CTX opaque.
@reaperhulk reaperhulk merged commit c5db584 into pyca:master May 19, 2015
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 006d879 on glyph:correct-structs into 8b8df23 on pyca:master.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

bugs

Milestone

Tenth Release

Development

Successfully merging this pull request may close these issues.

3 participants

@glyph @reaperhulk @coveralls