support prehashing in RSA sign #3238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@reaperhulk, thanks for your PR! By analyzing the history of the files in this pull request, we identified @alex, @cmurphy and @gorisaka to be potential reviewers. |
|
It feels like there was a substantial refactoring here, any chance of splitting that out? |
|
Ready for a rebase now. |
|
Needs a test for what happens if |
alex
reviewed
Nov 20, 2016
| @@ -167,6 +167,25 @@ There is a shortcut to sign sufficiently short messages directly: | |||
| ... hashes.SHA256() | |||
| ... ) | |||
|
|
|||
|
|
|||
| If you have pre-hashed your data you can sign using that as well: | |||
There was a problem hiding this comment.
I feel like this shouldn't be a part of the primary narrative, since it's relatively obscure. What do you think?
|
Needs a changelog entry |
alex
approved these changes
Nov 20, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support supplying previously hashed data to the
RSAPrivateKey.signmethod. Support for RSA verification and sign/verify for DSA/ECDSA will come in future PRs.This addresses part of #1648