Add mark that allows us to do skip tests on backends via decorators #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Err, sorry can you include the consumers of this mark and the removal of "only_if" from the generate functions, but not anything else? Sorry if my previous comment was confusing. |
|
Test PASSed. |
|
Test PASSed. |
| only_if=lambda backend: backend.hash_supported(hashes.SHA1), | ||
| skip_message="Does not support SHA1", | ||
| ) | ||
| def test_SHA1(self, backend): | ||
| base_hash_test(backend, hashes.SHA1(), digest_size=20, block_size=64) |
There was a problem hiding this comment.
The changes here with removing the generate_* stuff is what I didn't want to review in this patch, can bit be removed?
|
Test FAILed. |
alex
added a commit
that referenced
this pull request
Dec 28, 2013
Add mark that allows us to do skip tests on backends via decorators
joerichter-stash
pushed a commit
to kiwigrid/cryptography
that referenced
this pull request
Nov 15, 2017
check the result here
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splitting the actual pytest changes into a separate PR from #348.