Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose BN_rand operations #4118

Merged
merged 1 commit into from
Feb 23, 2018
Merged

Expose BN_rand operations #4118

merged 1 commit into from
Feb 23, 2018

Conversation

tuxxy
Copy link
Contributor

@tuxxy tuxxy commented Feb 23, 2018 •
edited
Loading

What this does:

  1. Exposes BN_rand and BN_rand_range in the OpenSSL backend.
  2. Solves Expose BN_rand operations? #4109

alex
alex reviewed Feb 23, 2018
View reviewed changes
tests/hazmat/backends/test_openssl.py Outdated
@@ -169,6 +169,32 @@ def test_bn_to_int(self):
bn = backend._int_to_bn(0)
assert backend._bn_to_int(bn) == 0

def test_bn_rand(self):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need tests for bindings like these. This code can be removed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alex alex merged commit 404496a into pyca:master Feb 23, 2018
@tuxxy tuxxy deleted the patch-expose_bn_rand branch February 23, 2018 20:58
@tuxxy tuxxy mentioned this pull request Mar 8, 2018
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alex alex alex approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tuxxy @alex