automatically set SSL_CTX_set_ecdh_auto when available #575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 95.65% (diff: 100%)@@ master #575 diff @@
==========================================
Files 16 16
Lines 5615 5620 +5
Methods 0 0
Messages 0 0
Branches 403 403
==========================================
+ Hits 5371 5376 +5
Misses 167 167
Partials 77 77
|
hynek
reviewed
Nov 22, 2016
| @@ -23,7 +23,8 @@ Deprecations: | |||
| Changes: | |||
| ^^^^^^^^ | |||
|
|
|||
| *none* | |||
| - Automatically set `SSL_CTX_set_ecdh_auto()` on ``OpenSSL.SSL.Context``. | |||
There was a problem hiding this comment.
Can you make SSL_CTX_set_ecdh_auto() a reST code too pls? Otherwise LGTM and you can merge it if the tests pass.
|
this needs a rebase (sorry, had the choice between your and pestering a newbie some more :)) |
reaperhulk
force-pushed
the
auto-ecdh
branch
from
c7ce289
to
0d65cea
Compare
hynek
approved these changes
Dec 19, 2016
|
Sorry, lost track of this. |
aszlig
added a commit
to NixOS/nixpkgs
that referenced
this pull request
Jun 21, 2017
Upstream changes: * Added OpenSSL.X509Store.set_time() to set a custom verification time when verifying certificate chains. pyca/pyopenssl#567 * Added a collection of functions for working with OCSP stapling. None of these functions make it possible to validate OCSP assertions, only to staple them into the handshake and to retrieve the stapled assertion if provided. Users will need to write their own code to handle OCSP assertions. We specifically added: Context.set_ocsp_server_callback, Context.set_ocsp_client_callback, and Connection.request_ocsp. pyca/pyopenssl#580 * Changed the SSL module's memory allocation policy to avoid zeroing memory it allocates when unnecessary. This reduces CPU usage and memory allocation time by an amount proportional to the size of the allocation. For applications that process a lot of TLS data or that use very lage allocations this can provide considerable performance improvements. pyca/pyopenssl#578 * Automatically set SSL_CTX_set_ecdh_auto() on OpenSSL.SSL.Context. pyca/pyopenssl#575 * Fix empty exceptions from OpenSSL.crypto.load_privatekey(). pyca/pyopenssl#581 The full upstream changelog can be found at: https://pyopenssl.readthedocs.io/en/17.0.0/changelog.html I've also added a patch from pyca/pyopenssl#637 in order to fix the tests, which was the main reason for the version bump because that patch won't apply for 16.2.0. According to the upstream changelog there should be no backwards-incompatible changes, but I've tested building against some of the packages depending on pyopenssl anyway. Regardless of this, the build for pyopenssl fails right now anyway, so the worst that could happen via this commit would be that we break something that's already broken. Signed-off-by: aszlig <aszlig@redmoonstudios.org>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #359