Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin pytest until we drop 2.6 #721

merged 1 commit into from Nov 28, 2017

Pin pytest until we drop 2.6 #721

merged 1 commit into from Nov 28, 2017


Copy link

@hynek hynek commented Nov 28, 2017

pytest 3.3 drops Python 2.6 and (ironically) Python 3.3.

I would of course much prefer to drop 2.6 and cryptography 2.2 is dropping 2.6 so an alternative PR to this one would be to kill 2.6 with fire if cryptography 2.2 is on a realistic horizon.

We need to do either of those two because otherwise our tests will fail.

Copy link

codecov bot commented Nov 28, 2017

Codecov Report

Merging #721 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #721   +/-   ##
  Coverage   97.03%   97.03%           
  Files          18       18           
  Lines        5669     5669           
  Branches      394      394           
  Hits         5501     5501           
  Misses        112      112           
  Partials       56       56

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 736c621...695dea4. Read the comment docs.

Copy link

@alexwlchan alexwlchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’d much prefer dropping Python 2.6 support, but this is fine for now. 👍

@alexwlchan alexwlchan merged commit f724786 into pyca:master Nov 28, 2017
Copy link

cryptography 2.2 is probably 4-8 weeks away (we haven't really done much work thus far).

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants