Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests and badges like CI, code coverage, etc. #4

Closed
hsluoyz opened this issue Mar 29, 2021 · 10 comments
Closed

Fix tests and badges like CI, code coverage, etc. #4

hsluoyz opened this issue Mar 29, 2021 · 10 comments
Assignees
Labels
enhancement New feature or request

Comments

@hsluoyz
Copy link
Member

hsluoyz commented Mar 29, 2021

image

@hsluoyz hsluoyz self-assigned this Mar 29, 2021
@hsluoyz hsluoyz added the enhancement New feature or request label Mar 29, 2021
@hsluoyz hsluoyz changed the title Add tests and badges like CI, code coverage, etc. Fix tests and badges like CI, code coverage, etc. Apr 5, 2021
@pycasbin pycasbin deleted a comment from Zxilly Apr 5, 2021
@pycasbin pycasbin deleted a comment from Zxilly Apr 5, 2021
@hsluoyz
Copy link
Member Author

hsluoyz commented Apr 5, 2021

@ashish493

@ashish493
Copy link
Contributor

Will start working on it.

@ashish493
Copy link
Contributor

@hsluoyz ,
In the line mentioned in the function of casbin_subscription, I couldn't find any type of attribute related to multiprocessing.connection.pipeconnection. I even tried seaching on official docs but couldn't find it. And if there isn't any such attribute, then rectifying it would be hard. :(

Also the postgreSQL action used in the CI only works for Linux. For mac and windows, I need to setup the postgreSQL manually for the CI.

@hsluoyz
Copy link
Member Author

hsluoyz commented Apr 7, 2021

@Zxilly any comment?

@Zxilly
Copy link
Contributor

Zxilly commented Apr 7, 2021

@ashish493 plz turn to @LiuG-lynx for help.
Maybe there's no need to test watcher on different platform? If you do want to test it on MacOS or Windows, you need to manually setup database.

@hsluoyz
Copy link
Member Author

hsluoyz commented May 11, 2021

@Zxilly

I guess @LiuG-lynx is not in the community any more. We need to resolve it by ourselves.

I don't think we need to run tests all so many OSs. Only testing against Linux is OK. But we need to just make sure the final code can run on all OSs, for example, don't use a Windows-specific API to make it fail to run on Linux.

@Zxilly
Copy link
Contributor

Zxilly commented May 12, 2021

@hsluoyz I'm working on cross platform support.

@hsluoyz
Copy link
Member Author

hsluoyz commented May 19, 2021

@Zxilly CI is fixed, thanks!

Coverage is still down.

image

@Zxilly
Copy link
Contributor

Zxilly commented May 20, 2021

@hsluoyz I will add it to CI.

@hsluoyz
Copy link
Member Author

hsluoyz commented Jun 25, 2021

Done:

image

@hsluoyz hsluoyz closed this as completed Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants