Skip to content

fix: made should_reload into a blocking call #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 17, 2022
Merged

fix: made should_reload into a blocking call #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
323bcd4
Made should_reload into a blocking call
stuartbeattie84 May 4, 2022
9a6c93a
Removed should_reload() unit test, as this will now wait forever.
stuartbeattie84 May 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions postgresql_watcher/watcher.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,6 @@ def create_subscriber_process(
)
if start_process:
p.start()
self.should_reload()
return p

def set_update_callback(self, fn_name: Callable):
Expand All @@ -113,7 +112,7 @@ def update(self):

def should_reload(self):
try:
if self.parent_conn.poll():
if self.parent_conn.poll(None):
message = self.parent_conn.recv()
print(f"message:{message}")
return True
Expand Down
3 changes: 0 additions & 3 deletions tests/test_postgresql_watcher.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,6 @@ def test_pg_watcher_init(self):
def test_update_pg_watcher(self):
assert pg_watcher.update() is True

def test_not_reload(self):
assert not pg_watcher.should_reload()

def test_default_update_callback(self):
assert pg_watcher.update_callback() is None

Expand Down