Filtered Policy Support #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@techoner @Xhy-5000 please review. |
|
LGTM. |
|
@techoner |
|
Fix: #14 |
leeqvip
approved these changes
Oct 3, 2020
|
Sorry that I found this PR broke our Travis CI, see: https://www.travis-ci.org/github/pycasbin/sqlalchemy-adapter/builds Actually we can't even make sure the following PRs are correct owing to the CI failure. So I will revert all the PRs and commits starting from this PR. The current faulty HEAD is switched to another branch for record: https://github.com/pycasbin/sqlalchemy-adapter/tree/pr15-broken A good thing is that we never released a version to pypi after this PR. So it's easier to revert.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for filter policies recently merged into pycasbin
Fix: #14