fix database connection timeout #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When casbin.Enforcer is created, Adapter.load_policy() will be called, but sqlalchemy session is not commited in Adapter.load_policy(). The connection to database is held all the time till the first database operation, if the time interval between casbin.Enforcer created and first database operation occurs, exceeds database timeout setting, database operations like add_policy() and remove_policy() will raise timeout exception.
|
@techoner @Xhy-5000 please review. |
|
LGTM. |
|
@techoner can you merge it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
casbin.Enforceris created,Adapter.load_policy()will be called,but sqlalchemy session is not commited in
Adapter.load_policy(). Theconnection to database is held all the time till the first database
operation, if the time interval between
casbin.Enforcercreated andfirst database operation occurs, exceeds database timeout setting, database
operations like
add_policy()andremove_policy()will raise timeoutexception.