Improve Efficiency #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vzts
commented
Oct 23, 2019
leeqvip
requested changes
Oct 23, 2019
|
In addition, can you merge the two commits into one? |
|
To be conservative and safe, I was trying to make a equivalence to the previous code. |
|
Hello, could you please check if the latest update is good to go? Thank you. |
Closed
leeqvip
approved these changes
Oct 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, thank you for this wonderful library!
I have some general suggestions on the code. Too many
ifs were kind of bothering.I've run the tests and it worked well.
Also, could you please release v0.1.0? I think it's ready.
I need
remove_filtered_policyfunction that was recently implemented, but it's not on pypi yet...