Incorrect behaviour for nested functions

[JensRantil]

If I check

def a():
    """Do something."""
    def b():
        """My other help function that's used in a()."""
        return 42

I will get the warning

test.py:2:4: PEP257 Return value type should be mentioned.

even though a() does not return anything.

[keleshev]

here is the code for the check:

def check_return_type(def_docstring, context, is_script):
    """PEP257 Return value type should be mentioned.

    However, the nature of the return value cannot be determined by
    introspection, so it should be mentioned.

    """
    if (not def_docstring) or is_script:
        return
    if 'return' not in def_docstring.lower():
        tokens = list(tk.generate_tokens(StringIO(context).readline))
        after_return = [tokens[i + 1][0] for i, token in enumerate(tokens)
                        if token[1] == 'return']
        # not very precise (tk.OP ';' is not taken into account)
        if set(after_return) - set([tk.COMMENT, tk.NL, tk.NEWLINE]) != set([]):
            return "PEP257 Return value type should be mentioned.",

As you can see it checks if there is a 'return' token in the body of function. In order to solve this bug the function should skip nested functions...

I will try to fix this when I have time, otherwise you're welcome to submit a patch.

[Nurdok]

This check is currently skipped, so I'm closing the issue for now.