Skip to content

[Bugfix] Unknown tool called by agent will cause response 400 #1255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 31, 2025
Merged

[Bugfix] Unknown tool called by agent will cause response 400 #1255

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ad890f0
all tool call id when agent call  unknown tool
BeautyyuYanli Mar 27, 2025
e6d1c13
try fix test
BeautyyuYanli Mar 27, 2025
9e424e9
again fix the test
BeautyyuYanli Mar 27, 2025
6f73f05
Merge branch 'main' into dev/fix_retry_part
BeautyyuYanli Mar 28, 2025
0e84a14
Merge branch 'main' into dev/fix_retry_part
BeautyyuYanli Mar 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions pydantic_ai_slim/pydantic_ai/_agent_graph.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -632,7 +632,7 @@ async def process_function_tools(
)
output_parts.append(part)
else:
output_parts.append(_unknown_tool(call.tool_name, ctx))
output_parts.append(_unknown_tool(call.tool_name, call.tool_call_id, ctx))

if not calls_to_run:
return
Expand Down Expand Up @@ -699,6 +699,7 @@ async def run_tool(ctx: RunContext[DepsT], **args: Any) -> Any:

def _unknown_tool(
tool_name: str,
tool_call_id: str,
ctx: GraphRunContext[GraphAgentState, GraphAgentDeps[DepsT, NodeRunEndT]],
) -> _messages.RetryPromptPart:
ctx.state.increment_retries(ctx.deps.max_result_retries)
Expand All @@ -711,7 +712,11 @@ def _unknown_tool(
else:
msg = 'No tools available.'

return _messages.RetryPromptPart(content=f'Unknown tool name: {tool_name!r}. {msg}')
return _messages.RetryPromptPart(
tool_name=tool_name,
tool_call_id=tool_call_id,
content=f'Unknown tool name: {tool_name!r}. {msg}',
)


async def _validate_result(
Expand Down
4 changes: 4 additions & 0 deletions tests/test_agent.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -818,6 +818,7 @@ def empty(_: list[ModelMessage], _info: AgentInfo) -> ModelResponse:
ModelRequest(
parts=[
RetryPromptPart(
tool_name='foobar',
content="Unknown tool name: 'foobar'. No tools available.",
tool_call_id=IsStr(),
timestamp=IsNow(tz=timezone.utc),
Expand Down Expand Up @@ -855,6 +856,7 @@ def empty(m: list[ModelMessage], _info: AgentInfo) -> ModelResponse:
ModelRequest(
parts=[
RetryPromptPart(
tool_name='foobar',
content="Unknown tool name: 'foobar'. No tools available.",
tool_call_id=IsStr(),
timestamp=IsNow(tz=timezone.utc),
Expand Down Expand Up @@ -1140,6 +1142,7 @@ def another_tool(y: int) -> int:
timestamp=IsNow(tz=timezone.utc),
),
RetryPromptPart(
tool_name='unknown_tool',
content="Unknown tool name: 'unknown_tool'. Available tools: regular_tool, another_tool, final_result",
timestamp=IsNow(tz=timezone.utc),
tool_call_id=IsStr(),
Expand Down Expand Up @@ -1233,6 +1236,7 @@ def another_tool(y: int) -> int: # pragma: no cover
timestamp=IsNow(tz=timezone.utc),
),
RetryPromptPart(
tool_name='unknown_tool',
content="Unknown tool name: 'unknown_tool'. Available tools: regular_tool, another_tool, final_result",
timestamp=IsNow(tz=timezone.utc),
tool_call_id=IsStr(),
Expand Down
3 changes: 2 additions & 1 deletion tests/test_streaming.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -578,6 +578,7 @@ def another_tool(y: int) -> int:
tool_call_id=IsStr(),
),
RetryPromptPart(
tool_name='unknown_tool',
content="Unknown tool name: 'unknown_tool'. Available tools: regular_tool, another_tool, final_result",
timestamp=IsNow(tz=timezone.utc),
tool_call_id=IsStr(),
Expand Down Expand Up @@ -699,7 +700,7 @@ def another_tool(y: int) -> int: # pragma: no cover
"'unknown_tool'. Available tools: "
'regular_tool, another_tool, '
'final_result',
tool_name=None,
tool_name='unknown_tool',
tool_call_id=IsStr(),
timestamp=IsNow(tz=datetime.timezone.utc),
part_kind='retry-prompt',
Expand Down