Gemini Video Support #1584
Gemini Video Support #1584
Conversation
PR Change SummaryAdded support for VideoUrl in Gemeni models and updated documentation accordingly.
Modified Files
How can I customize these reviews?Check out the Hyperlint AI Reviewer docs for more information on how to customize the review. If you just want to ignore it on this PR, you can add the Note specifically for link checks, we only check the first 30 links in a file and we cache the results for several hours (for instance, if you just added a page, you might experience this). Our recommendation is to add |
tests/models/test_gemini.py
Outdated
| ) | ||
|
|
||
| result = await agent.run(['Explain me this video', video_url]) | ||
| assert result.output.strip() == ( |
There was a problem hiding this comment.
Can you please use the snapshot helper here and up above? It should pass the assertion just the same, but will be easier to update if we ever re-run the request (skipping VCR) and the output changes slightly.
|
Think it's all set! |
|
@kylesf I think you forgot to push your new commit into the PR :) |
|
@DouweM :) |
There was a problem hiding this comment.
Can we please use a shorter video?
There was a problem hiding this comment.
Besides this, the PR seems perfect. 🙏
There was a problem hiding this comment.
@Kludex changed to 6 second video. Let me know if thats okay!
There was a problem hiding this comment.
If you make it 1 second, I press merge. 👀
(I can also do it if you are annoyed)
Summary
This pull request adds a new VideoUrl support to Gemeni and builds off MR #1435
Changes
Added support for VideoUrl to the Gemeni Models
Fix Doc Spelling Error
Type of Change
[x] Feature (new functionality)
[]Bug fix
[x] Documentation update
Checklist
[x] I have added tests
[x] I have updated the documentation
[x] I have performed a self-review of my own code
Not sure, what I may be missing. Let me know. Thanks