Minor fixes: Agent.__aenter__ returns Self, use default instrumentation for MCP sampling model
#2765
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on for MCP sampling model
alexmojaki
commented
Sep 2, 2025
| model_settings, | ||
| models.ModelRequestParameters(), | ||
| ) | ||
| model_response = await model_request(self.sampling_model, pai_messages, model_settings=model_settings) |
There was a problem hiding this comment.
This way logfire.instrument_pydantic_ai() will instrument the sampling model.
There was a problem hiding this comment.
Pull Request Overview
This PR makes two minor improvements to the codebase: updates the Agent.__aenter__ method to return Self for better type precision, and simplifies MCP sampling model instrumentation by using the default model_request function instead of manual model calls.
- Updates
Agent.__aenter__return type fromAbstractAgent[AgentDepsT, OutputDataT]toSelf - Replaces manual model request in MCP sampling callback with default instrumentation via
model_request
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pydantic_ai_slim/pydantic_ai/agent/init.py | Updates __aenter__ return type to Self and adds necessary import |
| pydantic_ai_slim/pydantic_ai/mcp.py | Refactors sampling callback to use model_request function and adds import |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Docs Preview
|
DouweM
approved these changes
Sep 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.