Support NativeOutput with FunctionModel
#2843
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add default ModelProfile with JSON schema and object output support when no profile is provided to FunctionModel - Update test_native_output to no longer pass custom profile since it's now the default - This enables testing native output pipeline in agents using FunctionModel Fixes #2839 🤖 Generated with [Claude Code](https://claude.ai/code) Co-authored-by: Douwe Maan <DouweM@users.noreply.github.com>
DouweM
commented
Sep 9, 2025
test_native_output_verification.py
Outdated
There was a problem hiding this comment.
@claude Remove this file, the modified test in test_agent.py is sufficient
There was a problem hiding this comment.
Claude finished @DouweM's task —— View job
Removing unnecessary test file ✅
Todo List:
- Read the file to understand what's being removed
- Remove
test_native_output_verification.py - Commit and push the changes
Completed! I've successfully removed the redundant test_native_output_verification.py file. The file contained a standalone test script that verified FunctionModel works with NativeOutput by default, but this functionality is already covered by the modified test in test_agent.py, making the standalone file unnecessary.
The change has been committed and pushed to the branch.
The functionality is already covered by the modified test in test_agent.py Co-authored-by: Douwe Maan <DouweM@users.noreply.github.com>
Docs Preview
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2839
Generated with Claude Code