Skip to content

Fix lints firing since rust 1.80 #1379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 30, 2024
Merged

Fix lints firing since rust 1.80 #1379

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
10c0554
Check in `speedate` Cargo.lock changes
BoxyUwU Jul 30, 2024
5aab429
Space out a comment
BoxyUwU Jul 30, 2024
7c36fe6
Specify has_coverage_attribute as a known cfg
BoxyUwU Jul 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions build.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ fn main() {
if let Some(true) = version_check::supports_feature("coverage_attribute") {
println!("cargo:rustc-cfg=has_coverage_attribute");
}
println!("cargo:rustc-check-cfg=cfg(has_coverage_attribute)");
generate_self_schema();
println!("cargo:rustc-env=PROFILE={}", std::env::var("PROFILE").unwrap());
}
3 changes: 2 additions & 1 deletion src/serializers/ob_type.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,7 +290,8 @@ impl ObTypeLookup {
/// We care about order here since:
/// 1. we pay a price for each `isinstance` call
/// 2. some types are subclasses of others, e.g. `bool` is a subclass of `int`
/// hence we put common types first
/// hence we put common types first
///
/// In addition, some types have inheritance set as a bitflag on the type object:
/// https://github.com/python/cpython/blob/v3.12.0rc1/Include/object.h#L546-L553
/// Hence they come first
Expand Down