Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/serializers/type_serializers/model.rs
Original file line number Diff line number Diff line change
Expand Up @@ -166,9 +166,13 @@ impl TypeSerializer for ModelSerializer {
if self.root_model {
extra.field_name = Some(ROOT_FIELD);
let py = value.py();
let root = value
.getattr(intern!(py, ROOT_FIELD))
.map_err(|_| PydanticSerializationUnexpectedValue::new_err(None))?;
let root = value.getattr(intern!(py, ROOT_FIELD)).map_err(|original_err| {
if extra.check.enabled() {
PydanticSerializationUnexpectedValue::new_err(None)
} else {
original_err
}
})?;
self.serializer.to_python(root, include, exclude, &extra)
} else if self.allow_value(value, &extra)? {
let inner_value = self.get_inner_value(value, &extra)?;
Expand Down
26 changes: 26 additions & 0 deletions tests/serializers/test_model_root.py
Original file line number Diff line number Diff line change
Expand Up @@ -179,3 +179,29 @@ class Model(RootModel):

assert s.to_python(m) == [1, 2, {'value': 'abc'}]
assert s.to_json(m) == b'[1,2,{"value":"abc"}]'


def test_construct_nested():
class RModel(RootModel):
root: int

class BModel(BaseModel):
value: RModel

s = SchemaSerializer(
core_schema.model_schema(
BModel,
core_schema.model_fields_schema(
{
'value': core_schema.model_field(
core_schema.model_schema(RModel, core_schema.int_schema(), root_model=True)
)
}
),
)
)

m = BModel(value=42)

with pytest.raises(AttributeError, match="'int' object has no attribute 'root'"):
s.to_python(m)