Skip to content

Make tests more robust to the running environment #464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 4, 2024
Merged

Make tests more robust to the running environment #464

merged 3 commits into from
Nov 4, 2024

Conversation

CyberTailor
Copy link
Contributor

Fixes #463

@CyberTailor
Fix running test_source_cli with unusual COLUMNS values
91ed1c2 
Tests expect help text to be wrapped at 80 characters.

Issue: pydantic#463
@CyberTailor
Strip environment for test_settings
00d1aac 
Certain variables, when set in the running environment, can make tests
fail. As environment variable names are case-insensitive by default,
it's better to start with a clean environment.

Issue: pydantic#463
@CyberTailor
Use temporary home directory for test_env_file_home_directory
cf4aa52 
Issue: pydantic#463
@hramezani
Copy link
Member

Thanks @CyberTailor

@hramezani hramezani merged commit 0922bc1 into pydantic:main Nov 4, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hramezani hramezani hramezani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tests need to strip environment variables before running
2 participants
@CyberTailor @hramezani