Skip to content

Fix order of fields in field validators example #8191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 21, 2023
Merged

Fix order of fields in field validators example #8191

merged 2 commits into from
Nov 21, 2023

Conversation

Viicos
Copy link
Member

@Viicos Viicos commented Nov 21, 2023 •
edited by pydantic-hooky bot
Loading

The docs say:

in the code above, for example, you would not be able to access info.data['id'] from within name_must_contain_space.

Which is true with this update

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer: @Kludex

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Nov 21, 2023 •
edited
Loading

CodSpeed Performance Report

Merging #8191 will not alter performance

Comparing Viicos:docs-field-order (b256c34) with main (fb81b32)

Summary

✅ 10 untouched benchmarks

@Viicos
Copy link
Member Author

Viicos commented Nov 21, 2023

Please review

sydney-runkle
sydney-runkle approved these changes Nov 21, 2023
View reviewed changes
Copy link
Contributor

@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@sydney-runkle sydney-runkle added the relnotes-ignore Omit this PR from the release notes. label Nov 21, 2023
@sydney-runkle
Copy link
Contributor

@Viicos, could you please fix the failing test?

@sydney-runkle sydney-runkle merged commit 8540b44 into pydantic:main Nov 21, 2023
@Viicos Viicos deleted the docs-field-order branch November 21, 2023 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@sydney-runkle sydney-runkle sydney-runkle approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@Kludex Kludex

Labels
ready for review relnotes-ignore Omit this PR from the release notes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Viicos @sydney-runkle @Kludex