Skip to content

ENH: add a timeout parameter (EDGAR tests hanging) #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 8, 2016
Merged

ENH: add a timeout parameter (EDGAR tests hanging) #234

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion pandas_datareader/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ class _BaseReader(object):
_format = 'string'

def __init__(self, symbols, start=None, end=None,
retry_count=3, pause=0.1, session=None):
retry_count=3, pause=0.1, timeout=30, session=None):
self.symbols = symbols

start, end = self._sanitize_dates(start, end)
Expand All @@ -55,6 +55,7 @@ def __init__(self, symbols, start=None, end=None,
raise ValueError("'retry_count' must be integer larger than 0")
self.retry_count = retry_count
self.pause = pause
self.timeout = timeout
self.session = self._init_session(session, retry_count)

def _init_session(self, session, retry_count):
Expand Down
2 changes: 1 addition & 1 deletion pandas_datareader/edgar.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ def _fix_old_file_paths(self, path):

def read(self):
try:
self._sec_ftp_session = FTP(_SEC_FTP)
self._sec_ftp_session = FTP(_SEC_FTP, timeout=self.timeout)
self._sec_ftp_session.login()
except EOFError:
raise RemoteDataError('FTP server has closed the connection.')
Expand Down