Repaired Morningstar volume for indicies #488
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Travis fails due to unrelated errors...since yesterday IEX Stock endpoints queries fail at random (Stats and Market data are OK). May want to add a warning for this-waiting for the provider's input first. |
|
@bashtage can you try restarting the Travis build on this? The conda install errored in 2.7/0.19.2 for some reason and the unrelated IEX provider issues should be resolved. That code wasn't really touched in this PR anyway. |
|
I restarted but it looked like there were failures against latest Pandas. |
|
@bashtage thanks. Looks like the second round passed. |
bashtage
reviewed
Feb 18, 2018
pandas_datareader/mstar/daily.py
Outdated
| if jsondata["VolumeList"]: | ||
| volumes = jsondata["VolumeList"]["Datapoints"] | ||
| else: | ||
| volumes = [np.nan] * 1000000 |
There was a problem hiding this comment.
Would be cleaner to set volumes to None
bashtage
reviewed
Feb 18, 2018
pandas_datareader/mstar/daily.py
Outdated
| @@ -192,7 +196,10 @@ def _restruct_json(self, symbol, jsondata): | |||
| else: | |||
| pass | |||
| if self.incl_vol is True: | |||
| bardict.update({"Volume": int(volumes[p] * 1000000)}) | |||
| try: | |||
| bardict.update({"Volume": int(volumes[p] * 1000000)}) | |||
There was a problem hiding this comment.
Then chck if volume is not None...
|
Thanks |
bashtage
pushed a commit
to bashtage/pandas-datareader
that referenced
this pull request
Apr 13, 2018
Repaired Morningstar volume for indicies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #486. Certain Morningstar (index) tickers now use
np.nanto indicate empty volume data. Thanks @ggomarr.git diff upstream/master -u -- "*.py" | flake8 --diff