Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run and archive lighthouse report on Circle CI artifact #208

Merged
merged 1 commit into from
Jun 23, 2020

Conversation

bollwyvl
Copy link
Collaborator

This is a smaller version of #206: as discussed over there, PRs that change the archive workflow are kind of hard to evaluate, so this only adds:

  • upgrade larsoner/circleci-artifacts-redirector-action
    • now with support for url
  • foo-software/lighthouse-check-action to run the report against the url
    • presently only runs against index.html... for now
  • actions/upload to archive the report to get an idea of the as-is state of the report

Future PRs will shave off more pieces of #206:

  • use foo-software/lighthouse-check-status-action to validate against the top-level scores (simple 0-100 integers) to prevent regressions
  • a few quick wins for performance, SEO and accessibility

@jorisvandenbossche
Copy link
Member

Thanks! Let's see how this goes when merged in master

@jorisvandenbossche jorisvandenbossche merged commit 64fde80 into pydata:master Jun 23, 2020
@jorisvandenbossche
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants