Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve sidebar search presentation #578

Merged
merged 1 commit into from
Jan 27, 2022
Merged

Improve sidebar search presentation #578

merged 1 commit into from
Jan 27, 2022

Conversation

pradyunsg
Copy link
Contributor

@pradyunsg pradyunsg commented Jan 26, 2022 •
edited by choldgraf
Loading

Use a complete rounded-border, instead of a bottom border.

Old:

image

New:

image

@pradyunsg
Improve sidebar search presentation
dd34d29 
Use a complete rounded-border, instead of a bottom border.
choldgraf
choldgraf approved these changes Jan 26, 2022
View reviewed changes
Copy link
Collaborator

@choldgraf choldgraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks quite nice - the border also makes it behave more sensibly when it has focus, IMO.

I'll give it a day or two to merge to see if anybody objects but LGTM!

@pradyunsg
Copy link
Contributor Author

pradyunsg commented Jan 26, 2022 •
edited
Loading

Screenshot 2022-01-26 at 21 14 54

Screenshot 2022-01-26 at 21 14 48

Screenshots presenting the change, in context of the page. First is from this PR.

@pradyunsg pradyunsg mentioned this pull request Jan 26, 2022
Merged
damianavila
damianavila approved these changes Jan 27, 2022
View reviewed changes
Copy link
Collaborator

@damianavila damianavila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I think it is a nice improvement in the discoverability of the search bar.

@damianavila damianavila merged commit 3bb4ed0 into pydata:master Jan 27, 2022
@pradyunsg pradyunsg deleted the patch-1 branch January 27, 2022 13:59
@choldgraf choldgraf mentioned this pull request Mar 25, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@choldgraf choldgraf choldgraf approved these changes

@damianavila damianavila damianavila approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pradyunsg @damianavila @choldgraf