Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing release in version switcher #656

Merged
merged 3 commits into from
May 6, 2022
Merged

Conversation

tupui
Copy link
Contributor

@tupui tupui commented May 6, 2022

0.8.1 is missing in the dropdown of the doc.

Also I changed the styling for the dev version to have the same border colour as the background colour. Otherwise there is a small blue which IMHO is not visually pleasing.

Note: you could have in the release CI a check to ensure this file has been updated.
Note 2: I am not sure it's needed to have 2 entries for the stable version if they point to the same version in the background (through different links, but still resolves to the same version).

Co-authored-by: Chris Holdgraf <choldgraf@gmail.com>
Copy link
Collaborator

@choldgraf choldgraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@choldgraf choldgraf changed the title Missing release in version switcher Add missing release in version switcher May 6, 2022
@choldgraf choldgraf merged commit a3754c8 into pydata:master May 6, 2022
@tupui tupui deleted the missing_rel branch May 6, 2022 12:22
@jarrodmillman jarrodmillman added this to the 0.9 milestone May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants