Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Docutils 0.18 deprecation #687

Merged
merged 4 commits into from
Jun 2, 2022
Merged

MAINT: Docutils 0.18 deprecation #687

merged 4 commits into from
Jun 2, 2022

Conversation

larsoner
Copy link
Contributor

@larsoner larsoner commented Jun 1, 2022

Avoids a PendingDeprecationWarning:

Traceback (most recent call last):
  File "/home/larsoner/python/sphinx/sphinx/builders/html/__init__.py", line 1072, in handle_page
    output = self.templates.render(templatename, ctx)
...
  File "/home/larsoner/python/pydata-sphinx-theme/src/pydata_sphinx_theme/__init__.py", line 172, in generate_nav_html
    toc_sphinx = index_toctree(app, pagename, startdepth, **kwargs)
  File "/home/larsoner/python/pydata-sphinx-theme/src/pydata_sphinx_theme/__init__.py", line 428, in index_toctree
  File "/home/larsoner/python/pydata-sphinx-theme/src/pydata_sphinx_theme/__init__.py", line 385, in _get_local_toctree_for
    meth = 'findall' if hasattr(doctree, 'findall') else 'traverse'
  File "/home/larsoner/.local/lib/python3.10/site-packages/docutils/nodes.py", line 240, in traverse
    warnings.warn('nodes.Node.traverse() is obsoleted by Node.findall().',
PendingDeprecationWarning: nodes.Node.traverse() is obsoleted by Node.findall().

@jarrodmillman jarrodmillman added this to the 0.9 milestone Jun 2, 2022
Co-authored-by: Jarrod Millman <jarrod.millman@gmail.com>
@choldgraf choldgraf merged commit adc9065 into pydata:main Jun 2, 2022
@larsoner larsoner deleted the findall branch June 2, 2022 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants