Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: Sourcelink and other Sphinx theme templates #714

Merged
merged 7 commits into from
Jun 16, 2022

Conversation

12rambau
Copy link
Collaborator

Fix #417

Add support for for html_show_copyright, html_show_sphinx and html_show_sourcelink.
The sourcelink was not in the theme so I customized a html template and set in in the "in page" information after the edit-this-page button.

Copy link
Collaborator

@choldgraf choldgraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me in general, a few quick thoughts/comments in there

@@ -33,7 +33,7 @@ navbar_center = navbar-nav.html
navbar_end = theme-switcher.html, navbar-icon-links.html
left_sidebar_end = sidebar-ethical-ads.html
footer_items = copyright.html, sphinx-version.html
page_sidebar_items = page-toc.html, edit-this-page.html
page_sidebar_items = page-toc.html, edit-this-page.html, sourcelink.html
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I'm +1 on adding this by default, though we should probably give a little bit of time to make sure others do not object

12rambau and others added 2 commits June 11, 2022 15:57
Co-authored-by: Chris Holdgraf <choldgraf@gmail.com>
…ourcelink.html

Co-authored-by: Chris Holdgraf <choldgraf@gmail.com>
Copy link
Collaborator

@choldgraf choldgraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - let's add this and see what folks think :-) maybe we'll need to add some docs to explain how to remove it or re-add it, but let's wait until folks actually want to do that first

@choldgraf choldgraf changed the title make the theme responsive to extra Sphinx parameters Add: Sourcelink and other Sphinx theme templates Jun 16, 2022
@choldgraf choldgraf merged commit 8500b1d into pydata:main Jun 16, 2022
@12rambau 12rambau deleted the html_show branch June 17, 2022 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for html_show_copyright, html_show_sphinx, html_show_sourcelink ?
2 participants