-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add: Sourcelink and other Sphinx theme templates #714
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me in general, a few quick thoughts/comments in there
src/pydata_sphinx_theme/theme/pydata_sphinx_theme/components/sourcelink.html
Show resolved
Hide resolved
src/pydata_sphinx_theme/theme/pydata_sphinx_theme/components/sourcelink.html
Outdated
Show resolved
Hide resolved
@@ -33,7 +33,7 @@ navbar_center = navbar-nav.html | |||
navbar_end = theme-switcher.html, navbar-icon-links.html | |||
left_sidebar_end = sidebar-ethical-ads.html | |||
footer_items = copyright.html, sphinx-version.html | |||
page_sidebar_items = page-toc.html, edit-this-page.html | |||
page_sidebar_items = page-toc.html, edit-this-page.html, sourcelink.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I'm +1 on adding this by default, though we should probably give a little bit of time to make sure others do not object
src/pydata_sphinx_theme/theme/pydata_sphinx_theme/components/sourcelink.html
Outdated
Show resolved
Hide resolved
…ourcelink.html Co-authored-by: Chris Holdgraf <choldgraf@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me - let's add this and see what folks think :-) maybe we'll need to add some docs to explain how to remove it or re-add it, but let's wait until folks actually want to do that first
Fix #417
Add support for for
html_show_copyright
,html_show_sphinx
andhtml_show_sourcelink
.The sourcelink was not in the theme so I customized a html template and set in in the "in page" information after the edit-this-page button.