Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos, use logging.warning #787

Merged
merged 2 commits into from
Jul 7, 2022
Merged

Fix typos, use logging.warning #787

merged 2 commits into from
Jul 7, 2022

Conversation

kinow
Copy link
Contributor

@kinow kinow commented Jul 6, 2022

Hi,

Two commits here, but happy to squash if necessary. Found a typo in the docs for new contributors (double "like" in https://pydata-sphinx-theme.readthedocs.io/en/stable/contribute/manual.html).

So I ran the PyCharm linter, and added the other typos found in code comments.

The other commit is for logging.warn, which was deprecated in 3.3 and is to be removed some day 👍

image

Thanks!
-Bruno

Copy link
Collaborator

@12rambau 12rambau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time for a PR! nothing to add from my side

Copy link
Collaborator

@choldgraf choldgraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

many thanks for all of these improvements :-) LGTM

@choldgraf choldgraf merged commit a467d50 into pydata:main Jul 7, 2022
@kinow kinow deleted the typos-warn branch July 7, 2022 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants