Update kitchen sink and script to update #819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
choldgraf
force-pushed
the
kitchen-sink-2
branch
from
695ff13
to
5a6cef9
Compare
12rambau
reviewed
Jul 18, 2022
|
Good point @12rambau - instead of manually adding them here, I suggested we add them to the sphinx themes gallery so that others can benefit from it too. Would that work? |
|
PR got merged! I just updated here as well |
12rambau
approved these changes
Jul 18, 2022
|
I though all the failing test were due to the prerelease but there actually the windows one that is failing as well. Any clue why ? |
|
Hmmm, maybe this? I applied the fix that PR implements to this one as well, so lets see if the tests pass now |
|
ok so for the gallery side I think the error comes from The path tothe file is set Unix style and need to be resolved for Windows. Very weird that it never raised a bug before |
12rambau
reviewed
Jul 19, 2022
Co-authored-by: Rambaud Pierrick <12rambau@users.noreply.github.com>
choldgraf
commented
Jul 19, 2022
choldgraf
commented
Jul 19, 2022
|
Got the CI/CD errors working, so will merge this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates our kitchen sink to use the latest pages from sphinx-themes.org . They are now laid out a little bit more nicely and are easier to follow. It also adds a little helper script to automate this in the future.
Check out the new kitchen sink here: