Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAINT: Open issue when dependency prereleases fail #899

Merged
merged 5 commits into from
Sep 20, 2022
Merged

MAINT: Open issue when dependency prereleases fail #899

merged 5 commits into from
Sep 20, 2022

Conversation

jarrodmillman
Copy link
Collaborator

Fix #898

@jarrodmillman jarrodmillman mentioned this pull request Aug 29, 2022
Merged
choldgraf
choldgraf reviewed Aug 29, 2022
View reviewed changes
Copy link
Collaborator

@choldgraf choldgraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This generally looks good to me, a few quick suggestions to clean up the logic a bit

.github/prerelease-template.md Outdated Show resolved Hide resolved
.github/workflows/prerelease.yml Outdated Show resolved Hide resolved
.github/workflows/prerelease.yml Outdated Show resolved Hide resolved
.github/workflows/prerelease.yml Show resolved Hide resolved
@jarrodmillman jarrodmillman marked this pull request as ready for review September 16, 2022 18:44
@jarrodmillman jarrodmillman added this to the 0.11 milestone Sep 16, 2022
choldgraf
choldgraf approved these changes Sep 18, 2022
View reviewed changes
Copy link
Collaborator

@choldgraf choldgraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me - ready to merge on your end? We might need to make some adjustments as we learn more but I think we should just give it a shot

@choldgraf choldgraf changed the title Open issue when dependency prereleases fail MAINT: Open issue when dependency prereleases fail Sep 20, 2022
@choldgraf choldgraf merged commit 0b29fea into pydata:main Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@choldgraf choldgraf choldgraf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.11
Development

Successfully merging this pull request may close these issues.

Make our pre-release CI job run on a CRON and open an issue instead of run on each pull request
2 participants
@jarrodmillman @choldgraf