set the content at the top of the page #916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
choldgraf
approved these changes
Sep 7, 2022
There was a problem hiding this comment.
It seems reasonable to me, although I'm not sure why we don't see this in our documentation. E.g. wouldn't we expect the "snap to bottom" to exist on this page:
https://pydata-sphinx-theme.readthedocs.io/en/stable/examples/persistent-search-field.html
?
Either way it seems fine to me 🤷
|
I think it's working on this very page because there's the prev-next footer, footer that I don't have in my documentation. |
|
Ahh that's why we didn't catch it then. Good find |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #908
In the current implementation we were using the "space-between" justification for
.bd-article-containeras there is now a.bd-header-articlebar as first item, the.bd-articleis systematically pushed at the bottom of the page.By using start we ensure that the content is always on top.