Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add expected pandas 1.5 warning #936

Merged
merged 1 commit into from
Sep 20, 2022
Merged

Add expected pandas 1.5 warning #936

merged 1 commit into from
Sep 20, 2022

Conversation

jarrodmillman
Copy link
Collaborator

@jarrodmillman jarrodmillman commented Sep 20, 2022 •
edited
Loading

Close #935. I didn't see any kitchen-sink warnings, so I replaced kitchen-sink with frame.py in .github/workflows/test.yml and .github/workflows/prerelease.yml.

@jarrodmillman jarrodmillman added this to the 0.11 milestone Sep 20, 2022
@jarrodmillman
Copy link
Collaborator Author

I think it might be worth revisitng how we check for unexpected Sphinx warnings (see #937). But, I think this should be merged ASAP so that the main branch doesn't have failing tests.

@jarrodmillman jarrodmillman marked this pull request as ready for review September 20, 2022 15:44
@drammock
Copy link
Collaborator

I didn't see any kitchen-sink warnings

that is surprising, as kitchen_sink intentionally contains things like broken cross-references.

@jarrodmillman
Copy link
Collaborator Author

that is surprising, as kitchen_sink intentionally contains things like broken cross-references.

hmm. I am not sure what is happening, but the tests are passing after I removed kitchen-sink.

12rambau
12rambau approved these changes Sep 20, 2022
View reviewed changes
Copy link
Collaborator

@12rambau 12rambau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @drammock but all the tests passed without complaining. Maybe sphinx 5 doesn't raise warnings on cross-referenced issues ?

I'll approve this PR because we don't want the tests to fail everywhere, let's dicuss the new implementation in #937

@jarrodmillman jarrodmillman mentioned this pull request Sep 20, 2022
Closed
@jarrodmillman
Copy link
Collaborator Author

I added a note to investigate what is going on with kitchen-sink not generating sphinx warnings in #937, so we won't forget.

@drammock
Copy link
Collaborator

Let's keep tests green.

@drammock drammock merged commit 9843963 into pydata:main Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@12rambau 12rambau 12rambau approved these changes

@drammock drammock drammock approved these changes

@choldgraf choldgraf Awaiting requested review from choldgraf

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.11
Development

Successfully merging this pull request may close these issues.

Pandas 1.5 release
3 participants
@jarrodmillman @drammock @12rambau