-
-
Notifications
You must be signed in to change notification settings - Fork 132
Closed
Labels
Description
I was considering allowing ndarray under elemwise again, provided that f(ndarrays, zeros_in_place_of_COO) is all-zero.
Upsides:
- No conversion required
- No matching/sorting required for the
ndarrayinputs at all. This makes it significantly faster for mixed sparse-denseelemwise.
Downsides:
- We'll have to broadcast all
ndarraysagainst each other to actually test for densification. This could be huge. Or we can skip this step and risk wrong results.- Not so bad considering in almost all use-cases, the
ndarrayswill be tiny compared toCOO.
- Not so bad considering in almost all use-cases, the
- Puts a slight (but not huge) roadblock for arbitrary fill-values.