Skip to content

Allow ndarray in elemwise again #124

@hameerabbasi

Description

@hameerabbasi

I was considering allowing ndarray under elemwise again, provided that f(ndarrays, zeros_in_place_of_COO) is all-zero.

Upsides:

  • No conversion required
  • No matching/sorting required for the ndarray inputs at all. This makes it significantly faster for mixed sparse-dense elemwise.

Downsides:

  • We'll have to broadcast all ndarrays against each other to actually test for densification. This could be huge. Or we can skip this step and risk wrong results.
    • Not so bad considering in almost all use-cases, the ndarrays will be tiny compared to COO.
  • Puts a slight (but not huge) roadblock for arbitrary fill-values.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions