Skip to content

Conversation

mtsokol
Copy link
Collaborator

@mtsokol mtsokol commented Jun 12, 2024

Hi @hameerabbasi,

Once we have new Finch.jl and finch-tensor releases in some time we can merge it, as we solved:

  • floor_divide return dtype mismatch
  • in matmul_example.py we can replace lazy indexing with actual @ operator as for the benchmarked case (on my machine) Finch is x40 times faster than Numba (and x7 times slower than SciPy)

@mtsokol mtsokol added the enhancement Indicates new feature requests label Jun 12, 2024
@mtsokol mtsokol self-assigned this Jun 12, 2024
@mtsokol
Copy link
Collaborator Author

mtsokol commented Jun 12, 2024

So I think matmul_example.py is written exactly as the user would write it and it shows speedup compared to Numba.

@hameerabbasi
Copy link
Collaborator

Thanks, @mtsokol. Waiting on the release and CI before I review.

@hameerabbasi
Copy link
Collaborator

Ping me when the release is up, I'll approve.

@mtsokol
Copy link
Collaborator Author

mtsokol commented Jun 18, 2024

@hameerabbasi The PR is ready (except for hanging Finch Array API job at 95%).

@hameerabbasi hameerabbasi merged commit cb951b3 into main Jun 18, 2024
@hameerabbasi hameerabbasi deleted the upgrade-finch branch June 18, 2024 15:55
@willow-ahrens
Copy link
Collaborator

Is the benchmark any faster with lazy indexing?

@mtsokol
Copy link
Collaborator Author

mtsokol commented Jun 19, 2024

Is the benchmark any faster with lazy indexing?

@willow-ahrens I would say matmul with the lazy notation is slightly faster but the notation a @ b is much closer to what user would write compared to lazy indexing form:

SIZE = 100000 x 100000
DENSITY = 0.00001
FORMAT = csr
ITERS = 3

######
# Finch a @ b
Finch
Took 0.040337721506754555 s.

Numba
Took 2.880397001902262 s.

SciPy
Took 0.0067259470621744795 s.
######
# Finch lazy indexing
Finch
Took 0.05138166745503744 s.

Numba
Took 2.861244281133016 s.

SciPy
Took 0.006536006927490234 s.
######

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Indicates new feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants