Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @hameerabbasi,
Once we have new
Finch.jl
andfinch-tensor
releases in some time we can merge it, as we solved:floor_divide
return dtype mismatchmatmul_example.py
we can replace lazy indexing with actual@
operator as for the benchmarked case (on my machine) Finch is x40 times faster than Numba (and x7 times slower than SciPy)